Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust the clean command and remove redundant changeset #1343

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore: adjust the clean command and remove redundant changeset #1343

merged 1 commit into from
Nov 28, 2023

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Nov 28, 2023 •
edited
Loading

What/Why/How?

Adjusting the npm run clean command to clear the dist/ folder as well.
Removing a redundant changeset.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023

⚠️ No Changeset found

Latest commit: 4eecc31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr self-assigned this Nov 28, 2023
@tatomyr tatomyr marked this pull request as ready for review November 28, 2023 10:33
@tatomyr tatomyr requested a review from a team as a code owner November 28, 2023 10:33
@github-actions GitHub Actions
Copy link
Contributor

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.026 ± 0.024 0.994 1.067 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.037 ± 0.020 1.019 1.075 1.01 ± 0.03

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 76.17% 4068/5341
🟡 Branches 66.07% 2167/3280
🟡 Functions 68.39% 660/965
🟡 Lines 76.36% 3815/4996

Test suite run success

652 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from 4eecc31

@tatomyr tatomyr merged commit 4497e75 into main Nov 28, 2023
29 checks passed
@tatomyr tatomyr deleted the chore/remove-redundant-changeset branch November 28, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorKarpiuk IgorKarpiuk IgorKarpiuk approved these changes

Assignees

@tatomyr tatomyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatomyr @IgorKarpiuk